[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

2022-04-21 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGaf3fb0715459: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D124177?vs=4

[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

2022-04-21 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:373 + } + llvm::StringRef filePath() const { return File->getFilePath(); } + llvm::StringRef memoryContents() co

[PATCH] D124177: [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

2022-04-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: adamcz. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Remove fiddly union, preambles are heavyweight - Remove fiddly move constructors i