adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:373 + } + llvm::StringRef filePath() const { return File->getFilePath(); } + llvm::StringRef memoryContents() const { return *Memory; } ---------------- Maybe add asserts here and below to check that Kind is indeed File or Memory? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124177/new/ https://reviews.llvm.org/D124177 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits