[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

zibi added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry -

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry --

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry --

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

zibi added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry -

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

thakis added a comment. Thanks, that did the trick :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added a comment. In D124039#3461482 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/33656/step_7.txt > > Please take a look and revert for now if it takes a while to fix. (Maybe just > needs an explicit triple?)

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/33656/step_7.txt Please take a look and revert for now if it takes a while to fix. (Maybe just needs an explicit triple?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG260c5df2d52b: [OpenMP] Add better testing for the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://re

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 updated this revision to Diff 423743. jhuber6 added a comment. Fix test on Windows failing because of ".exe" at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 Files: clang/test/Driver/

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice! I like the strategy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 ___

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, JonChesterfield, jdoerfert, tianshilei1992. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. T