This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4cec789c177d: [Testing] Drop clangTesting from clang's
public library interface (authored by sammccall).
Changed prior to commit:
https://reviews.
sammccall added inline comments.
Comment at: clang/lib/Testing/CMakeLists.txt:6
+# Not add_clang_library: this is not part of clang's public library interface.
+# Unit tests should depend on this with target_link_libraries, not clang_TLL.
+add_llvm_library(clangTesting
--
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The change makes sense to me.
Comment at: clang/lib/Testing/CMakeLists.txt:6
+# Not add_clang_library: this is not part of clang's public library interface.
+# Unit tests sho
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added a subscriber: mgorny.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This was probably not particularly intended to be