[PATCH] D123567: [clang][AVR] add more builtin macros

2022-04-11 Thread Ben Shi via Phabricator via cfe-commits
benshi001 abandoned this revision. benshi001 added a comment. In D123567#3444674 , @MaskRay wrote: > In D123567#3444613 , @benshi001 > wrote: > >> In D123567#3444579 , @M

[PATCH] D123567: [clang][AVR] add more builtin macros

2022-04-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D123567#3444613 , @benshi001 wrote: > In D123567#3444579 , @MaskRay wrote: > >> `avr-gcc -E -d

[PATCH] D123567: [clang][AVR] add more builtin macros

2022-04-11 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D123567#3444579 , @MaskRay wrote: > `avr-gcc -E -dM -xc /dev/null -dM | grep __avr` has no result, so I am not > sure this is correct. The reason I added these little case macros, is that I find other backend targets hav

[PATCH] D123567: [clang][AVR] add more builtin macros

2022-04-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. `avr-gcc -E -dM -xc /dev/null -dM | grep __avr` has no result, so I am not sure this is correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123567/new/ https://reviews.llvm.org/D123567

[PATCH] D123567: [clang][AVR] add more builtin macros

2022-04-11 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, dylanmckay. Herald added subscribers: StephenFan, Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor