MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed.
In D123567#3444613 <https://reviews.llvm.org/D123567#3444613>, @benshi001 wrote: > In D123567#3444579 <https://reviews.llvm.org/D123567#3444579>, @MaskRay wrote: > >> `avr-gcc -E -dM -xc /dev/null -dM | grep __avr` has no result, so I am not >> sure this is correct. > > The reason I added these little case macros, is that I find other backend > targets have, as shown in the compiler-rt's CMakefile, > https://github.com/llvm/llvm-project/blob/main/compiler-rt/cmake/Modules/CompilerRTUtils.cmake#L155 > > I think we need not strictly follow avr-gcc's way, my final goal is making > clang+llvm+compiler-rt+lld fully functional and can replace avr-gcc toolchain. > > I expect clang+llvm+compiler-rt+lld to be fully functioning against the > Arduino boards. (https://www.arduino.cc/). Err, this is not sufficient justification to introduce new preprocessor macros. Changing the predefined macro set to make an in-tree cmake function happy. I am unsure this is the right thing. If the cmake function isn't happy with a lowercase macro, can't you fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123567/new/ https://reviews.llvm.org/D123567 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
