[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Jennifer Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG187ccc66fa5d: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 ___

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 421657. jyu2 added a comment. Add test in cfg-openmp.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 Files: clang/include/clang/AST/OpenMPClause.h clang/include/

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Add a test to Analysis/cfg-openmp.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 421639. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/cla

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 421637. jyu2 added a comment. Thanks Alexey, for the review! This patch addresses his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 Files: clang/include/c

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. I think it worth it to add the analysis test for the clause Comment at: clang/lib/AST/OpenMPClause.cpp:1465 + + OMPHasDeviceAddrClause *Clause = + new (Mem) OMPHasDeviceAddrClause(Locs, Sizes); `auto *` Comment

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

2022-04-08 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: clang, OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. jyu2 requested review of this revision. Herald added subsc