[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

nkreeger added a comment. In D123182#3471789 , @erichkeane wrote: > In D123182#3471687 , @nkreeger > wrote: > >> In D123182#3471661 , @erichkeane >> wrote: >> >>> @nkre

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added a comment. In D123182#3471687 , @nkreeger wrote: > In D123182#3471661 , @erichkeane > wrote: > >> @nkreeger : Can you please explain your revert, both in the revert commit >> message (next time)

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

nkreeger added a comment. In D123182#3471661 , @erichkeane wrote: > @nkreeger : Can you please explain your revert, both in the revert commit > message (next time), as well as the patch so that the author/rest of us have > SOME hint as to why it was re

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added a subscriber: nkreeger. erichkeane added a comment. @nkreeger : Can you please explain your revert, both in the revert commit message (next time), as well as the patch so that the author/rest of us have SOME hint as to why it was reverted? Frequent reverts make it painful as a

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG807e418413a0: [Concepts] Fix overload resolution bug with constrained candidates (authored by royjacobson). Repository: rG LLVM Github Monorepo C

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 424747. royjacobson added a comment. Rebase after fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

Mordante added a comment. I've a fix in D124103 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 ___ cfe-commits mailing list

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

Mordante added a comment. In D123182#3458712 , @royjacobson wrote: > So, it seems like this broke one of `basic_arg_format`'s private > constructors.. Sorry for that. > > This is now ambiguous when calling `basic_format_arg(char)` because the > argumen

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added a subscriber: Mordante. royjacobson added a comment. So, it seems like this broke one of `basic_arg_format`'s private constructors.. Sorry for that. //format_arg.h:167 explicit basic_format_arg(_Tp __v) noexcept requires(same_as<_Tp, char_type> || (

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG454d1df9423c: [Concepts] Fix overload resolution bug with constrained candidates (authored by royjacobson). Repository: rG LLVM Github Monorepo C

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added a comment. Pretty sure those OMP bugs are unrelated, we've been seeing those a ton lately on just about every patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 _

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added a comment. Thanks @erichkeane! I will land this on Monday if there are no further comments and the CI looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 ___

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423229. royjacobson added a comment. Rebase again (HEAD CI was broken) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423169. royjacobson marked an inline comment as done. royjacobson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/Rele

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm happy with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 ___

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson marked 2 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9829 + bool CanCompareConstraints = false; + if (Cand1.Function && Cand2.Function && Cand1.Function->hasPrototype() && + Cand2.Function->hasPrototyp

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423120. royjacobson added a comment. Split the 'can compare constraints' code into a static function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: cla

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), royjacobson wrote: > erichkeane wrote: > > Thanks for the clar

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), erichkeane wrote: > Thanks for the clarification on 'Reversed

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423116. royjacobson marked an inline comment as not done. royjacobson added a comment. Update for look inside FunctionParamTypesAreEqual to be index based and simpler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), Thanks for the clarification on 'Reversed'. The comment makes

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2958 /// ArgPos will have the parameter index of the first different parameter. +/// If `Reversed` is true, exactly one of FT1 and FT2 is an overload +/// candidate with a reversed parameter order. --