nkreeger added a comment. In D123182#3471789 <https://reviews.llvm.org/D123182#3471789>, @erichkeane wrote:
> In D123182#3471687 <https://reviews.llvm.org/D123182#3471687>, @nkreeger > wrote: > >> In D123182#3471661 <https://reviews.llvm.org/D123182#3471661>, @erichkeane >> wrote: >> >>> @nkreeger : Can you please explain your revert, both in the revert commit >>> message (next time), as well as the patch so that the author/rest of us >>> have SOME hint as to why it was reverted? Frequent reverts make it painful >>> as a downstream, and confusing as a reviewer/implementer as to the state of >>> things. >> >> Apologies - I was reverting my commit and accidently had the wrong >> git-revert commit in my tree locally. I thought I had it cleaned up, but was >> wrong when I pushed. I ensured the tree was back in place with another >> revert. Please let me know if this is not the case. Sorry again :-( > > I see that now, thanks for the explanation! IN the future, even when > reverting your OWN commit, it is appreciated if you explain the WHY to the > revert so that it has some level of context. Particularly when you show some > sort of example of the failure (like a link to the broken bot, etc), as it > helps the downstream test-failure-analysis a ton. Roger noted - apologies again I felt horrible! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
