dexonsmith added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:318
FileEntryRef ReturnedRef(*NamedFileEnt);
- if (UFE.isValid()) { // Already have an entry with this inode, return it.
+ if (ReusingEntry) { // Already have an entry with this inode, return it.
sammccall added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:318
FileEntryRef ReturnedRef(*NamedFileEnt);
- if (UFE.isValid()) { // Already have an entry with this inode, return it.
+ if (ReusingEntry) { // Already have an entry with this inode, return it.
dexonsmith added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:318
FileEntryRef ReturnedRef(*NamedFileEnt);
- if (UFE.isValid()) { // Already have an entry with this inode, return it.
+ if (ReusingEntry) { // Already have an entry with this inode, return it.
dexonsmith added a comment.
Nice!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123144/new/
https://reviews.llvm.org/D123144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rGcf1c5507b725: FileManager: std::map => BumpPtrAllocator +
DenseMap of pointers. NFC (authored by sammccal
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks! maybe put an NFC in the patch name?
Comment at: clang/lib/Basic/FileManager.cpp:581
/// do directory look-up instead of file look-up.
-std::error_code
-FileManag
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added a subscriber: dexonsmith.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is both smaller and faster.
Reposito
