dexonsmith added inline comments.
================
Comment at: clang/lib/Basic/FileManager.cpp:318
FileEntryRef ReturnedRef(*NamedFileEnt);
- if (UFE.isValid()) { // Already have an entry with this inode, return it.
+ if (ReusingEntry) { // Already have an entry with this inode, return it.
----------------
I'm trying to figure out why `ReusingEntry` was necessary. It looks to me like
you could just call `UFE->isValid()` here and avoid introducing that `bool`...
or am I missing something?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123144/new/
https://reviews.llvm.org/D123144
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
