[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50de68bc2ffc: [Driver][AVR] Emit proper warnings for different options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); benshi001 wrote: > We should not merge the above two `if`, due to this check. > > So I will keep my or

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477 if (!LinkStdlib) D.Diag(diag::warn_drv_avr_stdlib_not_linked); We should not merge the above two `if`, due to this check

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nodefaultlibs)) { +if (!CPU.empty()) { MaskRay wrot

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:451 if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nodefaultlibs)) { +if (!CPU.empty

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 added a comment. In D122524#3411879 , @MaskRay wrote: > In D122524#3411872 , @benshi001 > wrote: > >> In D122524#3410542 , @MaskRay >> wrote: >> >>> I think it

[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options

benshi001 updated this revision to Diff 418764. benshi001 retitled this revision from "[clang][AVR] Emit proper warnings" to "[Driver][AVR] Emit proper warnings for different options". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122524/new/ https://reviews.llvm.org/D122524 Files: cl