[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

2022-03-29 Thread Zixu Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d34bafef56: [clang][extract-api] Add Objective-C protocol support (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

2022-03-28 Thread Zixu Wang via Phabricator via cfe-commits
zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:269 +// Collect symbol information. +StringRef Name = Decl->getName(); +StringRef USR = API.recordUSR(Decl); dang wrote: > I think we should be recording this in Stri

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

2022-03-28 Thread Zixu Wang via Phabricator via cfe-commits
zixuw updated this revision to Diff 418744. zixuw marked 2 inline comments as done. zixuw added a comment. Rebase upstream changes in D122446 : - Move the change of the `objc_interface.m` test to D122446 . Repository: rG LLV

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

2022-03-28 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:269 +// Collect symbol information. +StringRef Name = Decl->getName(); +StringRef USR = API.recordUSR(Decl); I think we should be recording this in StringAllocator =

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

2022-03-25 Thread Zixu Wang via Phabricator via cfe-commits
zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for Objective-C protocol declarations in ExtractAPI. Depends on D122446