beanz added inline comments.
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401
+// The current shader stage itself
+uint32_t StageInteger = StageInteger =
+(uint32_t)TI.getTriple().getEnvironment() -
erichkeane wrote:
> Why does this do a do
erichkeane added inline comments.
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401
+// The current shader stage itself
+uint32_t StageInteger = StageInteger =
+(uint32_t)TI.getTriple().getEnvironment() -
Why does this do a double-assign her
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd394f9f8970d: Add HLSL Language Option and Preprocessor
(authored by beanz).
Herald added subscribers: llvm-commits, hiraditya.
Herald added a review
beanz added inline comments.
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401-403
+uint32_t StageInteger = StageInteger =
+(uint32_t)TI.getTriple().getEnvironment() -
+(uint32_t)llvm::Triple::Pixel;
rnk wrote:
> This here suggests that
rnk accepted this revision.
rnk added a comment.
Herald added a subscriber: StephenFan.
lgtm
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401-403
+uint32_t StageInteger = StageInteger =
+(uint32_t)TI.getTriple().getEnvironment() -
+(uint32_t)llvm::Tri
pete accepted this revision.
pete added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122087/new/
https://reviews.llvm.org/D122087
___
cfe
beanz created this revision.
beanz added reviewers: MaskRay, tstellar, pete, jdoerfert, sheredom, kuhar,
antiagainst, nhaehnle, rnk.
Herald added a subscriber: dexonsmith.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project: clang.
Bringing in HLSL as a la
