[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e5715857abd: [clang][dataflow] Extend flow conditions from block terminators (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:90 + void VisitBinaryOperator(const BinaryOperator *S) { +auto *LHS = S->getLHS()->IgnoreParenImpCasts(); +assert(LHS != nullptr); xazax.hun wrote:

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev updated this revision to Diff 413523. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120984/new/ https://reviews.llvm.org/D120984 Files: clang/in

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

xazax.hun accepted this revision. xazax.hun added a comment. Thanks, with the new comments it is much clearer what is going on! Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:90 + void VisitBinaryOperator(const BinaryOperator *S) { +auto *LHS =

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:99 + const Environment &Env2, Value &MergedVal, + Environment &Env) { return false; xazax.hun wrote: > `M

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev updated this revision to Diff 413426. sgatev marked 5 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120984/new/ https://reviews.llvm.org/D120984 Files: clang/in

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:154 + + // `X v (X ^ Y ^ ...)` is logically equivalent to `X`. The common conditions + // have al

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:123 + if (Constraints1.empty() || Constraints2.empty()) { +// Disjunction of empty set and non-empty set is represented as empty set. +return JoinedConstraints;

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:99 + const Environment &Env2, Value &MergedVal, + Environment &Env) { return false; `MergedEnv`? Also,

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev updated this revision to Diff 412969. sgatev added a comment. Minor tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120984/new/ https://reviews.llvm.org/D120984 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow ana