sgatev added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:90
+ void VisitBinaryOperator(const BinaryOperator *S) {
+ auto *LHS = S->getLHS()->IgnoreParenImpCasts();
+ assert(LHS != nullptr);
----------------
xazax.hun wrote:
> We only expect `||` and `&&` to be terminators right? I wonder if we should
> add an assert so we get notified if the language gets extended with a new
> operator that we do not support yet.
Right. Adding an assert here sounds good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120984/new/
https://reviews.llvm.org/D120984
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
