On Thu, Aug 27, 2015 at 7:36 PM, Alexander Kornienko wrote:
> On Fri, Aug 28, 2015 at 1:23 AM, Aaron Ballman
> wrote:
>>
>> On Thu, Aug 27, 2015 at 7:20 PM, Alexander Kornienko
>> wrote:
>> > alexfh added a comment.
>> >
>> > In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote:
>> >
>
On Fri, Aug 28, 2015 at 1:23 AM, Aaron Ballman
wrote:
> On Thu, Aug 27, 2015 at 7:20 PM, Alexander Kornienko
> wrote:
> > alexfh added a comment.
> >
> > In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote:
> >
> >> While working on r246209, one of the build bots ran into an issue
> (
On Thu, Aug 27, 2015 at 7:20 PM, Alexander Kornienko wrote:
> alexfh added a comment.
>
> In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote:
>
>> While working on r246209, one of the build bots ran into an issue (commented
>> below) that has me slightly perplexed. The build break can
alexfh added a comment.
In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote:
> While working on r246209, one of the build bots ran into an issue (commented
> below) that has me slightly perplexed. The build break can be found at:
> http://lab.llvm.org:8011/builders/clang-x86_64-debia
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
While working on r246209, one of the build bots ran into an issue (commented
below) that has me slightly perplexed. The build break can be found at:
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/3
alexfh closed this revision.
alexfh added a comment.
Committed revision 245434.
http://reviews.llvm.org/D12081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia added a comment.
Ok, thanks! :)
http://reviews.llvm.org/D12081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! I'll fix the last issue (see the comment below) and commit the
patch for you.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:80
@@ +79,3 @@
+ bool NeedsSpa
angelgarcia updated this revision to Diff 32539.
angelgarcia marked 13 inline comments as done.
angelgarcia added a comment.
Fix comments.
http://reviews.llvm.org/D12081
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNullptr
alexfh added a comment.
Sorry for the delay. Here are some more comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:33
@@ -30,2 +32,3 @@
Opts["modernize-pass-by-value.IncludeStyle"] = "llvm"; // Also: "google".
+Opts["modernize-use-nullptr.UserNullMacros"
angelgarcia updated this revision to Diff 32311.
angelgarcia marked 9 inline comments as done.
angelgarcia added a comment.
Comments fixed.
http://reviews.llvm.org/D12081
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNullpt
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:16
@@ +15,3 @@
+
+using namespace clang::ast_matchers;
+using namespace clang;
nit: The list should be sorted.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp
angelgarcia updated this revision to Diff 32303.
angelgarcia added a comment.
Previous diff was not the newest one.
http://reviews.llvm.org/D12081
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNullptrCheck.cpp
clang-tidy/
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
Move UseNullptr from clang-modernize to modernize module
14 matches
Mail list logo
