aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment.
While working on r246209, one of the build bots ran into an issue (commented below) that has me slightly perplexed. The build break can be found at: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30516 What's also strange is that I could not reproduce that failure locally (MSVC 2015 debug build, Windows 10)... ================ Comment at: test/clang-tidy/modernize-use-nullptr-basic.cpp:2 @@ +1,3 @@ +// RUN: $(dirname %s)/check_clang_tidy.sh %s modernize-use-nullptr %t -- \ +// RUN: -std=c++98 -Wno-non-literal-null-conversion +// REQUIRES: shell ---------------- Sorry for bringing this up later, but how is this test supposed to work? nullptr is not a valid C++98 construct, and so I don't think we should be recommending fixes to use nullptr in this case. Is there a reason this test case is using -std=c++98 instead of -std=c++11? http://reviews.llvm.org/D12081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
