[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban closed this revision. yrouban added a comment. Closed by commit https://reviews.llvm.org/rG7fb39fb6d6665cd469557b43eb205cc32b0a7ac3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 __

[PATCH] D120713: [clangd] Make dexp command line options sticky

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:418 + // Protect IndexLocation, ExecCommand and ProjectRoot from being reset. + IndexLocation.setValue(IndexLocation, true /* initial */); + ExecCommand.setValue(ExecCommand, true /* i

[PATCH] D120713: [clangd] Make dexp command line options sticky

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:417 + + // Protect IndexLocation, ExecCommand and ProjectRoot from being reset. + IndexLocatio

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban added subscribers: jhenderson, lattner. yrouban added a comment. In D120713#3353481 , @lattner wrote: > I'm not a competent reviewer for clangd > >> ! In D120713#3353532 , @jhenderson >> wrote: > > I don'

[PATCH] D120713: [clangd] Make dexp command line options sticky

jhenderson resigned from this revision. jhenderson added a comment. I don't know anything about clangd either. Not sure why I was added as a reviewer :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 __

[PATCH] D120713: [clangd] Make dexp command line options sticky

lattner resigned from this revision. lattner added a comment. Herald added a project: All. I'm not a competent reviewer for clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 _

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban created this revision. yrouban added reviewers: jhenderson, lattner, jpienaar, mehdi_amini. yrouban added a project: clang. Herald added subscribers: usaxena95, kadircet, arphaman. yrouban requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Hera