sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Thank you! ================ Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:417 + + // Protect IndexLocation, ExecCommand and ProjectRoot from being reset. + IndexLocation.setValue(IndexLocation, true /* initial */); ---------------- nit: comment echoes the code, say why instead? Preserve global options when flag parser is reset, so commands can use them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
