[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added a comment. I have left, (some quite harsh opinions on this idea here, I'm sorry): https://github.com/llvm/llvm-project/issues/54137 If you do want to contribute can I suggest you start with an item off this list, I think it will give you good insight into what is involved wi

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3352051 , @MyDeveloperDay wrote: > Does it need to be so "cloak and dagger"? ;-) No, you're right it doesn't have to be this way. > We always welcome patches, but please think about logging the idea in github > issues

[PATCH] D120712: [clang-format][docs] handle explicit enum values

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. This is just a formality for the hold back. I have no opinion on the actual change. (I keep myself out of the python stuff.) Repository: rG LLVM Github Mon

[PATCH] D120712: [clang-format][docs] handle explicit enum values

HazardyKnusperkeks added a comment. Herald added a project: All. In D120712#3352051 , @MyDeveloperDay wrote: > Does it need to be so "cloak and dagger"? ;-) > > We always welcome patches, but please think about logging the idea in github > issues (and

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added subscribers: HazardyKnusperkeks, owenpan, curdeius. MyDeveloperDay added a comment. Does it need to be so "cloak and dagger"? ;-) We always welcome patches, but please think about logging the idea in github issues (and assigning it to yourself), and use the good will of the

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3351889 , @MyDeveloperDay wrote: >> My reasoning was that I'm going to introduce an explicit enum value > > Any reason why? Yes, I but where's the fun if I told you now ;) . Just kidding. I don't want to go into the deta

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:174-175 return '* ``%s`` (in configuration: ``%s``)\n%s' % ( -self.name, -re.sub('.*_', '', self.config), +self.clean_name, +self.clean_config, do

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added a comment. > My reasoning was that I'm going to introduce an explicit enum value Any reason why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120712/new/ https://reviews.llvm.org/D120712 _

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:174-175 return '* ``%s`` (in configuration: ``%s``)\n%s' % ( -self.name, -re.sub('.*_', '', self.config), +self.clean_name, +self.clean_config, doxygen2rst(i

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3351014 , @MyDeveloperDay wrote: > I'm not quite sure how I feel about adding functionality that doesn't > actually do anything. I hear you. My reasoning was that I'm going to introduce an explicit enum value sometime s

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added a comment. I'm not quite sure how I feel about adding functionality that doesn't actually do anything. Comment at: clang/docs/tools/dump_format_style.py:174-175 return '* ``%s`` (in configuration: ``%s``)\n%s' % ( -self.name, -re.sub('

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk created this revision. kwk added a reviewer: FederAndInk. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there was this enum definition before: struct FormatStyle { //... /// Different styles for aligning after ope