sammccall added a comment.
Thought about this some more, and talked to @hokein offline.
I want to make sure there's consensus on "desired behavior" before documenting
it, to avoid too much confusion.
https://discourse.llvm.org/t/template-representation-in-ast-and-rav-with-explicit-instantiations
nridge added a comment.
will leave approval to hokein, but LGTM
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:172
- /// Return whether this visitor should recurse into
- /// template instantiations.
+ /// Return whether we should traverse of AST nodes that were
sammccall updated this revision to Diff 411640.
sammccall added a comment.
Move the description of shouldVisitTemplateInstantiations() to RAV.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120498/new/
https://reviews.llvm.org/D120498
Files:
clan
sammccall added inline comments.
Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Templates.cpp:12
+//
+// shouldVisitTemplateInstantiations() controls traversal of AST nodes that
+// were created by instantiation, rather than by written code. This means:
hokein added inline comments.
Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Templates.cpp:12
+//
+// shouldVisitTemplateInstantiations() controls traversal of AST nodes that
+// were created by instantiation, rather than by written code. This means:
---
sammccall created this revision.
sammccall added reviewers: hokein, nridge.
Herald added subscribers: usaxena95, kadircet, mgorny.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang.
There are several logical inconsisten
