nridge added a comment. will leave approval to hokein, but LGTM
================ Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:172 - /// Return whether this visitor should recurse into - /// template instantiations. + /// Return whether we should traverse of AST nodes that were created by + /// template instantiation, rather than by written code. ---------------- nit: stray "of" ================ Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Templates.cpp:283 + VisitClassTemplateSpecializationDecl + VisitFieldDecl +TraverseClassTemplateSpecializationDecl ---------------- Is this a FIXME (body is traversed is an instantiation declaration)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120498/new/ https://reviews.llvm.org/D120498 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
