[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. I've submitted the fix in `4dfec37037f5`. As for testing, unfortunately I couldn't just extend the `SemaOpenCL/fdeclare-opencl-builtins.cl` test: the OpenCL 1.2 RUN lines explicitly disable the `cl_intel_subgroups` extension (which is the extension that brings in `sub_g

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

hvdijk added a comment. In D120254#3419369 , @svenvh wrote: > In D120254#3419221 , @hvdijk wrote: > >> The problem is that this change enables certain built-ins in OpenCL 1.2 that >> take a memory_scope argument,

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. In D120254#3419221 , @hvdijk wrote: > This was worked around by modifying tests, but I believe this is a > fundamental problem in this change and was able to reproduce the error with > plain old clang: > > $ cat test.cl > voi

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

hvdijk added a comment. Herald added a project: All. In D120254#3342551 , @dyung wrote: > Hi, our internal release build bots are showing failures in two clang-tidy > tests that I bisected back to your commit, > clang-tidy/checkers/altera-id-dependent-b

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. Thanks, I could reproduce the problem with your cmake line. I have uploaded a fix for review in https://reviews.llvm.org/D120470 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120254/new/ https://reviews.llvm.org/D120254 _

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. If it helps, this is the cmake command I am using to build using gcc on linux: CMake command: -G Ninja -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_VERSION_SUFFIX= -DLLVM_BUILD_RUNTIME=ON -DLLVM_TOOL_LLD_BUILD=OFF "-DLLVM_LIT_ARGS=--verbose -j80 --no-progress-bar --max-tests 10"

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. In D120254#3342570 , @svenvh wrote: > In D120254#3342551 , @dyung wrote: > >> Hi, our internal release build bots are showing failures in two clang-tidy >> tests that I bisected back to you

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added a comment. In D120254#3342551 , @dyung wrote: > Hi, our internal release build bots are showing failures in two clang-tidy > tests that I bisected back to your commit, > clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and > cla

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

dyung added a comment. Hi, our internal release build bots are showing failures in two clang-tidy tests that I bisected back to your commit, clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, both are exhi

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. svenvh marked an inline comment as done. Closed by commit rGaa9c2d19d9b7: [OpenCL] Align subgroup builtin guards (authored by svenvh). Repository: rG LLVM Github Mon

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif azabaznov wrote: > svenvh wrote: > > I'm

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif --

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

fonzvermund added a comment. http://webonlinegambling.idea.informer.com/ https://webonlinegambling.com/mobile-casinos/ http://playlegalsportsbetting.idea.informer.com/ http://legalsportsbetting.idea.informer.com/ https://sourceforge.net/u/legalsportsbet/profile https://www.theodysseyonline.com/use

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

fonzvermund added a comment. https://njonlinecasinos.webgarden.com/casinos/nj-casino-reviews/tropicana-online-casino http://playlegalsportsbetting.com/borgata-online-casino-pa/ https://casinowatchnj.com/borgata-online-casino/ https://casinowatchnj.com/betmgm-online-casino/ https://casinowatchpa.co

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif I'm in doubt whether we could just reuse `__opencl_c_subgroups` for this? Repos

[PATCH] D120254: [OpenCL] Align subgroup builtin guards

svenvh created this revision. svenvh added a reviewer: azabaznov. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now, subgroup builtins are available with `opencl-c.h` when a