svenvh marked an inline comment as done. svenvh added inline comments.
================ Comment at: clang/lib/Headers/opencl-c-base.h:85 +// Internal feature macro to provide subgroup builtins. +#define __opencl_subgroup_builtins 1 +#endif ---------------- azabaznov wrote: > svenvh wrote: > > I'm in doubt whether we could just reuse `__opencl_c_subgroups` for this? > I think we couldn't. Those subgroup features/extensions are different, as > implementation may support the extension but not the feature. The difference > is in subgroup independent forward progress: for example, it's required by > the extension, but optional in OpenCL C 3.0 feature. Thanks for confirming, I will keep the separate internal feature macro then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120254/new/ https://reviews.llvm.org/D120254 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
