[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added a comment. @vvereschaka I have a fix out in D124203 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 ___ cfe-c

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added a comment. In D119996#3465735 , @vvereschaka wrote: > Hi @paulkirth, > > using of specific triple within `stack-usage-safestack.c` test causes a > failure for the compilers, which don't support these triples (arm/aarch64 in > my case).

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

vvereschaka added a comment. Hi @paulkirth, using of specific triple within `stack-usage-safestack.c` test causes a failure for the compilers, which don't support these triples (arm/aarch64 in my case). Such as: error: unable to create target: 'No available targets are compatible with triple

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. paulkirth marked an inline comment as done. Closed by commit rG61e36e87df1a: [safestack] Support safestack in stack size diagnostics (authored by paulkirth). Repositor

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/test/Frontend/stack-usage-safestack.c:3 + +// RUN: %clang_cc1 %s -fwarn-stack-size=48 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=REGULAR %s +// RUN: %clang_cc1 %s -fwarn-stack-

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 419493. paulkirth added a comment. Herald added a subscriber: pengfei. Update tests. - Dont rely on size of `int` based on platform - Add checking to backend tests for warn-stack-size to ensure the behavior is consistant when safestack is enabled Reposit

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

serge-sans-paille added inline comments. Comment at: clang/test/Frontend/stack-usage-safestack.c:1 +/// Check that stack frame size warnings behave the same when safe stack is enabled + I think this should be a bitcode-level test à la test/CodeGen/X86/warn-stack

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 419222. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 Files: clang/test/Frontend/stack-usage-safestack.c llvm/include/llvm/C

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added subscribers: seaneveson, MatzeB. paulkirth added a comment. @MatzeB @seaneveson Can either of you confirm that the logic we're inserting here is not in conflict with the stack size section? Based on D39788 and the original RFC, I would say accoun

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 413556. paulkirth added a comment. Update emitStackSection to emit the size of the combined stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 Files: clang/tes

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1211 const MachineFrameInfo &FrameInfo = MF.getFrameInfo(); - uint64_t StackSize = FrameInfo.getStackSize(); + uint64_t StackSize = + FrameInfo.getStackSize() + FrameInfo.getUnsafeSt

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

mcgrathr added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1211 const MachineFrameInfo &FrameInfo = MF.getFrameInfo(); - uint64_t StackSize = FrameInfo.getStackSize(); + uint64_t StackSize = + FrameInfo.getStackSize() + FrameInfo.getUnsafeSta

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth created this revision. Herald added a subscriber: hiraditya. paulkirth updated this revision to Diff 409705. paulkirth added a comment. paulkirth updated this revision to Diff 409797. tstellar added a subscriber: serge-sans-paille. paulkirth edited the summary of this revision. paulkirth