[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D119612: [clang] Pass more flags to ld64.lld

This revision was automatically updated to reflect the committed changes. Closed by commit rG383ed82dd1f8: [clang] Pass more flags to ld64.lld (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/n

[PATCH] D119612: [clang] Pass more flags to ld64.lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above

[PATCH] D119612: [clang] Pass more flags to ld64.lld

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm! Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shoul

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added a comment. lld-macho folks, any concerns with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409254. thakis added a comment. Pass `-B` with `-fuse-ld=lld` since the latter flag only has an effect if ld64.lld exists on disk, and clang/test doesn't depend on lld (and shouldn't). Also move object_path_lto to its own file since it can run fine on non-dar

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis updated this revision to Diff 409243. thakis added a comment. undo no_deduplicate bit again for now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-ld-lto.c cl

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above a

[PATCH] D119612: [clang] Pass more flags to ld64.lld

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-ld-dedup.c:4 +// -no_deduplicate is only present from ld64 version 262 and later, or lld. +// RUN: %clang -target x86_64-apple-darwin10 -### -fuse-ld= %s \ // RUN: -mlinker-version=261 -O0 2>&1 | FileCheck -ch

[PATCH] D119612: [clang] Pass more flags to ld64.lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above

[PATCH] D119612: [clang] Pass more flags to ld64.lld

lgrey added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242 } else if (D.getLTOMode() == LTOK_Thin) // If we are using thin LTO, then create a directory instead. TmpPathName = D.GetTemporaryDirectory("thinlto"); thakis w

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242 } else if (D.getLTOMode() == LTOK_Thin) // If we are using thin LTO, then create a directory instead. TmpPathName = D.GetTemporaryDirectory("thinlto"); lgrey:

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis created this revision. thakis added a reviewer: lld-macho. Herald added subscribers: ormris, steven_wu, hiraditya. thakis requested review of this revision. - ld64.lld now completely supports -export_dynamic (D119372 ), so map -rdynamic to -export_dynamic