This revision was automatically updated to reflect the committed changes.
Closed by commit rG0b41238ae7f9: [AArch64] Emit TBAA metadata for SVE
load/store intrinsics (authored by sdesmalen).
Changed prior to commit:
https://reviews.llvm.org/D119319?vs=407060&id=407804#toc
Repository:
rG LLVM
sdesmalen added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:888
if (isAllActivePredicate(Pred)) {
-Builder.CreateStore(VecOp, VecPtr);
+auto *Store = Builder.CreateStore(VecOp, VecPtr);
+Store->copyMetadata(II);
-
paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.
I cannot say I fully understand all the connotations of this change but my gut
feeling is that if failures occur it's likely the input program is malformed.
Either way, we're
sdesmalen created this revision.
Herald added subscribers: ctetreau, jeroen.dobbelaere, kosarev, hiraditya,
kristof.beyls, tschuett.
sdesmalen requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
In Clang we can attach TBAA me