This revision was automatically updated to reflect the committed changes.
Closed by commit rL250398: Clang support for -flto=thin. (authored by
tejohnson).
Changed prior to commit:
http://reviews.llvm.org/D11908?vs=36453&id=37478#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11908
Files
joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Ping.
Thanks,
Teresa
On Sat, Oct 3, 2015 at 6:51 PM, Teresa Johnson wrote:
> tejohnson updated this revision to Diff 36453.
> tejohnson added a comment.
>
> - Rename code gen option to EmitFunctionSummary as per review for
> http://reviews.llvm.org/D13107.
> - Clang format the latest changes.
>
tejohnson updated this revision to Diff 36453.
tejohnson added a comment.
- Rename code gen option to EmitFunctionSummary as per review for
http://reviews.llvm.org/D13107.
- Clang format the latest changes.
Let me know if it looks good now.
http://reviews.llvm.org/D11908
Files:
include/cl
> On 2015-Oct-02, at 08:59, Teresa Johnson wrote:
>
> On Fri, Oct 2, 2015 at 8:53 AM, Manuel Klimek wrote:
>> klimek added a comment.
>>
>> In http://reviews.llvm.org/D11908#258570, @tejohnson wrote:
>>
>>> Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi
>>> for s
On Fri, Oct 2, 2015 at 8:53 AM, Manuel Klimek wrote:
> klimek added a comment.
>
> In http://reviews.llvm.org/D11908#258570, @tejohnson wrote:
>
>> Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi
>> for some reason. Trying again...
>>
>> In http://reviews.llvm.org/D119
On Fri, Oct 2, 2015 at 9:44 AM, Teresa Johnson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
As David mentioned, "inlineonly" is much too restrictive for what is
> possible. I prefer to stick with "thin" since it refers to this new model
> of keeping the whole program part very thin.
>
Agr
klimek added a comment.
In http://reviews.llvm.org/D11908#258570, @tejohnson wrote:
> Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi
> for some reason. Trying again...
>
> In http://reviews.llvm.org/D11908#258540, @klimek wrote:
>
> > Perhaps "sharded" would fit what
tejohnson added a comment.
Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi for
some reason. Trying again...
In http://reviews.llvm.org/D11908#258540, @klimek wrote:
> Perhaps "sharded" would fit what it is?
You could have a sharded mode for full FDO (like gcc's par
tejohnson added a subscriber: tejohnson.
tejohnson added a comment.
Added echristo, rafael, pcc officially as subscribers as Duncan's cc
of them via email didn't stick.
http://reviews.llvm.org/D11908
___
cfe-commits mailing list
cfe-commits@lists.ll
klimek added a subscriber: klimek.
klimek added a comment.
Perhaps "sharded" would fit what it is?
http://reviews.llvm.org/D11908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davidxl added a comment.
ThinLTO is a perfectly good term to indicate what it tries to accomplish.
InlineOnly will narrow its scope. For instance, there is no reason why thinLTO
can not do fast summary based WPA in the future.
http://reviews.llvm.org/D11908
_
alexr added a subscriber: alexr.
alexr added a comment.
I realize that we've all been referring to this as ThinLTO, but is that
necessarily descriptive for users? What about inlineonly or something similar?
http://reviews.llvm.org/D11908
___
cfe-co
tejohnson updated this revision to Diff 36267.
tejohnson added a comment.
Address review comments.
Instead of -fthinlto use -flto=thin, and add in -flto=full as an alias to the
existing -flto. Add tests to check for proper overriding of -flto variants on
the command line, and convert grep tests
On Wed, Sep 30, 2015 at 2:33 PM, Duncan P. N. Exon Smith
wrote:
> +echristo, +espindola, +pcc
>
>> On 2015-Sep-30, at 12:39, Teresa Johnson wrote:
>>
>> On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith
>> wrote:
>>>
On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
On Wed,
+echristo, +espindola, +pcc
> On 2015-Sep-30, at 12:39, Teresa Johnson wrote:
>
> On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith
> wrote:
>>
>>> On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
>>>
>>> On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
>>> wrote:
On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith
wrote:
>
>> On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
>>
>> On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
>> wrote:
>>>
On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
tejohnson updated this revision to D
> On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
>
> On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
> wrote:
>>
>>> On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
>>>
>>> tejohnson updated this revision to Diff 35527.
>>> tejohnson added a comment.
>>>
>>> Updated the patch for
On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith
wrote:
>
>> On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
>>
>> tejohnson updated this revision to Diff 35527.
>> tejohnson added a comment.
>>
>> Updated the patch for the new LLVM/gold patch
>> (http://reviews.llvm.org/D13107).
>>
>>
> On 2015-Sep-23, at 10:28, Teresa Johnson wrote:
>
> tejohnson updated this revision to Diff 35527.
> tejohnson added a comment.
>
> Updated the patch for the new LLVM/gold patch
> (http://reviews.llvm.org/D13107).
>
> Two changes:
>
> - I put back the original change to pass a new plugin o
tejohnson updated this revision to Diff 35527.
tejohnson added a comment.
Updated the patch for the new LLVM/gold patch (http://reviews.llvm.org/D13107).
Two changes:
- I put back the original change to pass a new plugin option to gold. Since the
function index design/name has been generalized
tejohnson added inline comments.
Comment at: include/clang/Driver/Options.td:685
@@ -684,1 +684,3 @@
def fno_lto : Flag<["-"], "fno-lto">, Group;
+def fthinlto : Flag<["-"], "fthinlto">, Flags<[CC1Option]>, Group;
+def fno_thinlto : Flag<["-"], "fno-thinlto">, Group;
davidxl added a subscriber: davidxl.
Comment at: include/clang/Driver/Options.td:685
@@ -684,1 +684,3 @@
def fno_lto : Flag<["-"], "fno-lto">, Group;
+def fthinlto : Flag<["-"], "fthinlto">, Flags<[CC1Option]>, Group;
+def fno_thinlto : Flag<["-"], "fno-thinlto">, Group;
tejohnson updated the summary for this revision.
tejohnson updated this revision to Diff 31937.
tejohnson added a comment.
Removed gold plugin option.
http://reviews.llvm.org/D11908
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cp
tejohnson created this revision.
tejohnson added reviewers: rafael, dexonsmith.
tejohnson added a subscriber: cfe-commits.
Add clang support for -fthinlto option, which is used to set the
EmitThinLTOIndex code gen option on compiles, and the thinlto
gold plugin option on links.
Dependent on LLVM/
25 matches
Mail list logo
