[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

hvdijk added a comment. In D118935#3399095 , @Fznamznon wrote: > I was under impression that the change is small and therefore easy to > understand. Would some comment like "SYCL re-uses OpenCL mode diagnostics to > emit errors in case the cast happens

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

keryell added a comment. Yes, your comment idea looks good and helpful to me. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118935/new/ https://reviews.llvm.org/D118935 ___ cfe-commits mailing li

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon added a comment. > I misread what was done with addrspace_cast, that new operator only allows > conversions that are otherwise also allowed. Based on that, this change does > actually align with what was done for OpenCL mode, it does not restrict > anything that is allowed in OpenCL m

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

keryell added a comment. In D118935#3389452 , @hvdijk wrote: > It does make sense, then. A slightly more verbose commit message might have > helped though :) Even better, some comments in the code explaining the "why" would have helped. The commit mess

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

hvdijk added a comment. Herald added a project: All. Hi, what is the rationale here? This reuses the logic that was written for OpenCL mode, but in OpenCL mode, it was made an error with the idea that a new keyword `addrspace_cast` could be used in those cases where the user actually wants an a

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cee9608982a: [SYCL] Disallow explicit casts between mismatching address spaces (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118935/new/ https://reviews.llvm.org/D118935

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon created this revision. Fznamznon added a reviewer: bader. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev