keryell added a comment. In D118935#3389452 <https://reviews.llvm.org/D118935#3389452>, @hvdijk wrote:
> It does make sense, then. A slightly more verbose commit message might have > helped though :) Even better, some comments in the code explaining the "why" would have helped. The commit messages disappear while the comments are right there when the code is read/reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118935/new/ https://reviews.llvm.org/D118935 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
