[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

This revision was automatically updated to reflect the committed changes. Closed by commit rGc95cb4de1b66: [clang][dataflow] Intersect ExprToLoc when joining environments (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added a comment. Thanks, this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/ https://reviews.llvm.org/D117754 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > sgat

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev updated this revision to Diff 401615. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/ https://reviews.llvm.org/D117754 Files: clang/li

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); sgatev wrote: > xazax.hun wrote: > > sgatev wrote: > > > xaza

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev marked 2 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > sgat

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); sgatev wrote: > xazax.hun wrote: > > xazax.hun wrote: > > > A

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > xaza

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev updated this revision to Diff 401581. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/ https://reviews.llvm.org/D117754 Files: clang/li

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); xazax.hun wrote: > Are we sure that the memory addresses of C

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); Are we sure that the memory addresses of CFGBlocks are stable

[PATCH] D117754: [clang][dataflow] Intersect ExprToLoc when joining environments

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow