xazax.hun added inline comments.
================ Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:49 + // in tests. + std::set<const CFGBlock *> Preds; Preds.insert(Block.pred_begin(), Block.pred_end()); ---------------- xazax.hun wrote: > Are we sure that the memory addresses of CFGBlocks are stable enough for a > deterministic order? Alternatively, we could use the block ids for the > ordering. Also, could you describe where the flakiness is originated from? Naively, I'd expect that the order in which we process the predecessors should not change the results of the analysis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117754/new/ https://reviews.llvm.org/D117754 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
