[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

JonChesterfield added inline comments. Comment at: clang/lib/AST/Decl.cpp:1080 + if (const VarDecl *VD = dyn_cast(D)) +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(VD)) + return LinkageInfo(LV.getLinkage(), DefaultVisibility, false); Possibl

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 added a subscriber: ronlieb. jhuber6 added a comment. In D117362#3254681 , @JonChesterfield wrote: > If I'm following correctly, this broke the amdgpu buildbot and it has been > moved into staging as a workaround. I haven't debugged what breaks

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

JonChesterfield added a comment. If I'm following correctly, this broke the amdgpu buildbot and it has been moved into staging as a workaround. I haven't debugged what breaks but 'DefaultVisibility' is relatively likely to behave differently on cuda vs hsa systems so that's my first guess. =

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd081bfcd17c1: [OpenMP] Remove hidden visibility for declare target variables (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, let's hope this solves all the AMDGPU issues we've seen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/ https://reviews.llv

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 updated this revision to Diff 400328. jhuber6 added a comment. Updating again, wasn't handling static variables declared in a record context properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/ https://reviews.llvm.org/D11736

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 updated this revision to Diff 400292. jhuber6 added a comment. Changing method to use an early exit, previously visibility would still be hidden for some constructs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/ https://reviews

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch changes the visiblity of variables de