JonChesterfield added inline comments.
================ Comment at: clang/lib/AST/Decl.cpp:1080 + if (const VarDecl *VD = dyn_cast<VarDecl>(D)) + if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(VD)) + return LinkageInfo(LV.getLinkage(), DefaultVisibility, false); ---------------- Possibly address space dependent. I'm not confident shared or thread local variables will behave sensibly if annotated with elf visibility flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/ https://reviews.llvm.org/D117362 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits