[PATCH] D117056: [clangd] Properly compute framework-style include spelling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dfd11324eb0: [clangd] Properly compute framework-style include spelling (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ h

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 406081. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang-tools-ex

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 403361. dgoldman marked an inline comment as done. dgoldman added a comment. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-ex

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! LG with a couple of optional nits. Cut should be on 2022-02-01 or thereabouts, best to land after that if it's not a problem. Comment at: clang-tools-extra/cla

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401746. dgoldman added a comment. Split up HeaderSearch change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollecto

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added a comment. In D117056#3256538 , @sammccall wrote: > This looks good now, only blocker is dropping the change to LookupFile > somehow. > > Is it valuable to land this before the imminent 14 branch cut? I think it's > OK but as an indexing

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:326 +auto Path = FE->getName(); +auto It = CachePathToFrameworkSpelling.find(Path); +if (It != CachePathToFrameworkSpelling.end()) sammccall wrote: > any re

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401671. dgoldman marked 4 inline comments as done. dgoldman added a comment. Support private headers + private umbrellas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D1170

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

sammccall added a comment. This looks good now, only blocker is dropping the change to LookupFile somehow. Is it valuable to land this before the imminent 14 branch cut? I think it's OK but as an indexing change a crash has the possibility to be really disruptive, and most of the rest of us are

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1052 HFI.IndexHeaderMapHeader = 1; +} else if (CurDir->isFramework()) { + size_t SlashPos = Filename.find('/'); sammccall wrote: > This looks like a separate change, and

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:295 +if (!R.second && !R.first->second.empty()) { + // Framework has known umbrella spelling, cache it for this header as + // well. sammccall wrote: > Wh

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401422. dgoldman marked 18 inline comments as done. dgoldman added a comment. Changes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

sammccall added a comment. Nice! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:197 + llvm::StringMap CachePathToFrameworkSpelling; + llvm::StringMap CacheFrameworkToUmbrellaInclude; ...ToUmbrellaHeaderSpelling? (Unclear to me what values "

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 399336. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clan

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. With this chang