[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2023-09-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: PiotrZSL. Herald added a project: All. Is this change still relevant or can we close the PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-25 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 403050. njames93 added a comment. Simplify check logic to only detect loop inits with 0 and incriment with 1. Functionality can be introduced with later patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-19 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 401241. njames93 added a comment. Uploaded wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.tx

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-19 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 401234. njames93 marked an inline comment as done. njames93 added a comment. Use inheriting constructor for check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875 Fil

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-19 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.h:25-26 +public: + InefficientArrayTraversalCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Na

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-16 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. Except for a couple nits, LGTM. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.h:25-26 +public: + InefficientArrayTraversalCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Co

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-15 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 400266. njames93 added a comment. Add support for array access `Arr[I * JExtent + J]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875 Files: clang-tools-extra/clan

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-09 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.cpp:63 +hasLHS(ToDecl), +hasRHS(integerLiteral(equals(1)), +

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-09 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.cpp:63 +hasLHS(ToDecl), +hasRHS(integerLiteral(equals(1)), +

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-09 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 398404. njames93 marked 4 inline comments as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875 Files: clang-tools-ex

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-08 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.cpp:59 + // TODO: Add support for x [+-]= 1 and x = x [+-] 1 + hasIncrement(unaryOperator(hasUnaryOperand(ToDecl), +

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2022-01-08 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, kristof.beyls, xazax.hun, mgorny. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Adds a check th