njames93 marked an inline comment as done.
njames93 added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.h:25-26
+public:
+ InefficientArrayTraversalCheck(StringRef Name, ClangTidyContext *Context)
+ : ClangTidyCheck(Name, Context) {}
+ void registerMatchers(ast_matchers::MatchFinder *Finder) override;
----------------
LegalizeAdulthood wrote:
> If you're not doing anything different, I believe you can just do
> `using ClangTidyCheck::ClangTidyCheck;`
>
> Also, shouldn't you be explicitly overriding the d'tor?
> `~InefficientArrayTraversalCheck() override = default;`
No need to explicitly override the d'tor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116875/new/
https://reviews.llvm.org/D116875
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
