[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Herald added a project: All. Abandoning this. We don't need to collect usage info from -fimplicit-module-maps because we don't use that feature during explicit builds: D120465 . Support for usag

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

ahoppen accepted this revision. ahoppen added a comment. This revision is now accepted and ready to land. Ah, in that case it makes sense as-is. I just assumed they lived in the same library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116751/new

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 added a comment. In D116751#3227243 , @ahoppen wrote: > I just want to make sure that we don’t accidentally introduce a new > instantiation of a `Module` that doesn’t go through `makeModule` in the > future. I understand that, but I'm not

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

ahoppen added a comment. I just want to make sure that we don’t accidentally introduce a new instantiation of a `Module` that doesn’t go through `makeModule` in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116751/new/ https://reviews.

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 added a comment. In D116751#3227142 , @ahoppen wrote: > I suppose the idea is that all `Module` creations should go through > `makeModule`, right? In that case I think we should either > > - make the `Module` constructor private and `ModuleM

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

ahoppen added a comment. I suppose the idea is that all `Module` creations should go through `makeModule`, right? In that case I think we should either - make the `Module` constructor private and `ModuleMap` a friend of `Module` - or at least add a doc comment to the `Module` constructor that sa

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, ahoppen. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extracts the construction of `Module` within `ModuleMap` into a separ