jansvoboda11 added a comment. In D116751#3227243 <https://reviews.llvm.org/D116751#3227243>, @ahoppen wrote:
> I just want to make sure that we don’t accidentally introduce a new > instantiation of a `Module` that doesn’t go through `makeModule` in the > future. I understand that, but I'm not sure that's a desirable restriction in all situations. Moreover, `Module` resides in the `clangBasic` library while `ModuleMap` resides in `clangLex`. Befriending `ModuleMap` or otherwise tying `Module` to `ModuleMap` violates the library layering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116751/new/ https://reviews.llvm.org/D116751 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
