This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61d547e82494: [Clang][AArch64][ARM] PMUv3 Option Added
(authored by mubashar_).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
mubashar_ updated this revision to Diff 400518.
mubashar_ marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116748/new/
https://reviews.llvm.org/D116748
Files:
clang/test/Driver/aarch64-perfmon.c
llvm/include/llvm/Support/AArch64TargetParser.def
llvm/i
dmgreen accepted this revision.
dmgreen added a comment.
LGTM. Thanks for the update.
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:147
AARCH64_ARCH_EXT_NAME("sme-i64", AArch64::AEK_SMEI64, "+sme-i64",
"-sme-i64")
+AARCH64_ARCH_EXT_NAME("pmuv3",
mubashar_ updated this revision to Diff 399685.
mubashar_ added a comment.
The command line option for Clang is now +pmuv3 to enable PerfMon.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116748/new/
https://reviews.llvm.org/D116748
Files:
clang/test/Driver/aarch64-perfmon.c
llvm/i
dmgreen added a comment.
Hmm. This appears to be mapping pmuv3p4 to "perfmon". But "perfmon" has been
around a long time, not a new feature related to the pmuv3p4 update. It seems
on the AArch64 side to control access to PMCCNTR, i.e. access to the base
FEAT_PMUv3.
On the Arm side this is alte
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd17fb46e8945: [Clang][AArch64][ARM] PMUv3.4 Option Added
(authored by mubashar_).
Changed prior to commit:
https://reviews.llvm.org/D116748?vs=397
lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.
I'm happy with this patch, but you could update the description to be clearer
that you're adding an option to allow PMU v3.4 to be enabled/disabled
separately to the architecture - not adding
mubashar_ created this revision.
mubashar_ added a reviewer: lenary.
Herald added subscribers: hiraditya, kristof.beyls.
mubashar_ requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Performance monitor architecture extension
