[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

ychen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:223-224 const llvm::Triple &Triple, const ArgList &Args, + llvm::opt::ArgStr

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35737df4dcd2: [Clang][AArch64][ARM] Unaligned Access Warning Added (authored by mubashar_). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

pbarrio accepted this revision. pbarrio added a comment. This revision is now accepted and ready to land. LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 ___ cfe-commits mailing list cfe-co

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary accepted this revision. lenary added a comment. LGTM. I've looked a lot closer at the tests this time around, and am happy with them, and I think the message is phrased better, and there shouldn't be warnings with `-cc1as`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/ne

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 400827. mubashar_ added a comment. Addressed comments from @lenary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/include/clang/Basic/Di

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 400572. mubashar_ marked 8 inline comments as done. mubashar_ added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. This is coming together well. I think structs `U23` to `U26` in the C test are duplicates - how about surrounding them all in `#pragma pack(push, 2)` so they're different from the earlier cases? Quite a few more comments inline on the tests. Comment

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 399271. mubashar_ set the repository for this revision to rG LLVM Github Monorepo. mubashar_ added a comment. Windows tests are now expected to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. Reverted for the moment in rG3aec4b3d348d69e6c1ead7cba54677b855293983 while we fix the windows tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D11622

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

thakis added a comment. Thanks for the patch! 1. When committing code, please add "Differential Revision: https://reviews.llvm.org/D116221"; as last line to your commit description, to link the commit to the review. See `git log` for many examples. 2. This breaks tests on Windows, see e.g. ht

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. This caused some driver test failures. They have been fixed in https://reviews.llvm.org/rG11c67e5a4e99f51ec66c9781710f81955cfd5e24 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 ___

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary accepted this revision. lenary added a comment. LGTM! Thanks for your hard work on this! I think you've addressed @pbarrio's comments on this, and I'm not sure when he's back, so wait 48h before landing this, in case there are further comments. CHANGES SINCE LAST ACTION https://review

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 397322. mubashar_ marked 2 inline comments as done. mubashar_ added a comment. Enabled warning whenever +strict-align is present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 Files: clang/include/cl

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. Two quick comments about when this is enabled, and then I'm happy! Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:772-774 if (KernelOrKext) Features.push_back("+strict-align"); else if (Arg *A = Args.getLastArg(options::OPT_mno_unaligned

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 396151. mubashar_ edited the summary of this revision. mubashar_ added a comment. Cleaned up code to make it more clang format friendly. Added another test suite in C. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

pbarrio requested changes to this revision. pbarrio added a comment. This revision now requires changes to proceed. Suggest clarifying the commit message to something like: "Added warning for potential cases of unaligned access when option -mno-unaligned-access has been specified". Nice testing

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ created this revision. mubashar_ added a reviewer: lenary. Herald added a subscriber: kristof.beyls. mubashar_ requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A warning for when potential cases of unaligned access with option -mno