thakis added a comment.

Thanks for the patch!

1. When committing code, please add "Differential Revision: 
https://reviews.llvm.org/D116221"; as last line to your commit description, to 
link the commit to the review. See `git log` for many examples.

2. This breaks tests on Windows, see e.g. 
http://45.33.8.238/win/52066/step_7.txt Please take a look, and revert for now 
if it takes a while to fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116221/new/

https://reviews.llvm.org/D116221

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to