This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rGf2b3e25f860e: [clangd] Add CompileFlags.Compiler option to
override argv0 (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D116196?v
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ConfigFragment.h:140
+/// The name can affect how flags are parsed (clang++ vs clang).
+/// If the executable name is in the --query-driver allowlist, then it
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/ConfigFragment.h:140
+/// The name can affect how flags are parsed (clang++ vs clang).
+/// If the executable name is
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is separate from --query
