This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe1db505b42f4: [syntax][pseudo] Introduce the C++ spec
grammar. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
hokein updated this revision to Diff 405904.
hokein marked 2 inline comments as done.
hokein added a comment.
rebase and address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115856/new/
https://reviews.llvm.org/D115856
Files:
clang/li
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:40
+# gram.basic
+# !Custom modifications to eliminate optional declaration-seq
+translation-unit := declaration
hokein added inline comments.
Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:27
+# FIXME:
+# - support annotations (lazy parsing, contextual identifiers)
+# - empty input should be parsed successfully (special-case it?)
sammccall wrote:
> I think we shou
hokein updated this revision to Diff 401561.
hokein marked an inline comment as done.
hokein added a comment.
add new line to eof
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115856/new/
https://reviews.llvm.org/D115856
Files:
clang/lib/Tooling
hokein updated this revision to Diff 401559.
hokein marked 7 inline comments as done.
hokein added a comment.
address comments and add lit test to verify cxx.bnf
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115856/new/
https://reviews.llvm.org/D11
sammccall added inline comments.
Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:12
+# - attributes are omitted, which will be handled as comments;
+# - we don't allow nullable non-terminal symbols (except translation-unit).
+#There are few nullable non-terminals in the
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: mgorny.
hokein requested review of this revision.
Herald added a project: clang.
Also, add a dummy clang-pseudo tool (right now it accepts and parses the
grammar file).
Repository:
rG LLVM Github Monor
