sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:40
+# gram.basic
+# !Custom modifications to eliminate optional declaration-seq
+translation-unit := declaration-seq
----------------
nit: `#! Custom` might be more obvious than `# !Custom`


================
Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:683
+# gram.lex
+# As we use clang lexer, most of lexical symbols are not needed, we only add
+# needed literals.
----------------
there should be a #! somewhere here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115856/new/

https://reviews.llvm.org/D115856

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to