[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. In D115610#3304289 , @urnathan wrote: > the landed version is good, with Richard's suggested member name change. > Can't see a way of post-commit accepting? Yeah, maybe we can't do post-commit accept formally. Repository:

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

urnathan added a comment. the landed version is good, with Richard's suggested member name change. Can't see a way of post-commit accepting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 _

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3504937dfb2b: [C++20] [Modules] Don't create multiple global module fragment (authored by ChuanqiXu). Repository: rG LL

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. Although this wasn't accepted formally, both @urnathan and @rsmith says this looks good to them. So I guess it might not be bad to land this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 _

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu updated this revision to Diff 406315. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp clang/test/CXX/module/modul

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

rsmith added a comment. Thanks, this looks functionally good to me. I'm happy for this to land with the `Sema` member renamed. Comment at: clang/lib/Sema/SemaModule.cpp:727 +ModuleMap &Map = PP.getHeaderSearchInfo().getModuleMap(); +GlobalModuleFragmentCache = Map.crea

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. In D115610#3269265 , @urnathan wrote: > Seems good to me, @iains you've been looking at this? According to the discussion in https://github.com/llvm/llvm-project/issues/51682, it looks like Iains plans to implement something

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu updated this revision to Diff 403130. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaModule.cpp clang/test/CXX/module/module

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

tbaeder added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2217 + /// The gloabl module fragment of the current tranlation unit. + clang::Module *GlobalModuleFragmentCache = nullptr; Typos in "gloabl" and "tranlation" in the comment. Any reaso

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

urnathan added a comment. Seems good to me, @iains you've been looking at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, erichkeane, hubert.reinterpretcast. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Since the serialization code would recognize modu