ChuanqiXu added a comment. In D115610#3269265 <https://reviews.llvm.org/D115610#3269265>, @urnathan wrote:
> Seems good to me, @iains you've been looking at this? According to the discussion in https://github.com/llvm/llvm-project/issues/51682, it looks like Iains plans to implement something like P1184R2 (I found that is your paper!) in clang. So I added him before. (Might you make the status as green?) ================ Comment at: clang/include/clang/Sema/Sema.h:2217 + /// The gloabl module fragment of the current tranlation unit. + clang::Module *GlobalModuleFragmentCache = nullptr; ---------------- tbaeder wrote: > Typos in "gloabl" and "tranlation" in the comment. Any reason to call this a > "cache"? This was confusing to me at first. This is consistent with the current style in Sema. You could find many example by searching `Cache;` in Sema.h. I think the semantic is "Cache something to avoid search/create again". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
