[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:495 + InstrProfKind getProfileKind() const override { +InstrProfKind ProfileKind = InstrProfKind::Unknown; mtrofin wrote: > This looks a lot like line 290, can it

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:284-287 + FE = 0x1, // A frontend clang profile, incompatible with other attrs. + IR = 0x2, // An IR-level profile (default when -fprofile-generate is used). + BB = 0x4, // A profile with entry

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

mtrofin added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:495 + InstrProfKind getProfileKind() const override { +InstrProfKind ProfileKind = InstrProfKind::Unknown; This looks a lot like line 290, can it be refactored (or a

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13d89477be56: [InstrProf][NFC] Refactor Profile kind into a bitset enum. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 403746. snehasish added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 Files: llvm/include/llvm/ProfileData/InstrProf.h llvm/include/llvm/Pr

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:281-282 +/// An enum describing the attributes of an instrumented profile. +enum class InstrProfKind { + Unknown = 0x0, ellis wrote: > I've been working on a new coverage in

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:281-282 +/// An enum describing the attributes of an instrumented profile. +enum class InstrProfKind { + Unknown = 0x0, I've been working on a new coverage instrumentation in D1

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 398018. snehasish added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 Files: llvm/include/llvm/ProfileData/InstrProf.h llvm/include/llvm/Pr

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added a comment. Herald added a subscriber: ellis. ping @xur Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 ___ cfe-commits mailing list cfe-commits@

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added a comment. @xur Could you please take a look with a focus on ensuring that this change retains the semantics that you expect? Previously there were different enum values which indicated CS+IR vs IR only. Now the IR bit is set for both cases (to be consistent with the version mas

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/include/llvm/ProfileData/InstrProfWriter.h:48 public: - InstrProfWriter(bool Sparse = false, bool InstrEntryBBEnabled = false); ~InstrProfWri

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:93 - virtual bool isIRLevelProfile() const = 0; - tejohnson wrote: > It seems like these helper methods could still be defined using the new > bitset, which would red

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 392938. snehasish added a comment. Remove extra line in PGOInstrumentation.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 Files: llvm/include/llvm/ProfileDa

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 392937. snehasish added a comment. Reintroduce the helpers while keeping the bitset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115393/new/ https://reviews.llvm.org/D115393 Files: llvm/include/llvm/Prof

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

tejohnson added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:93 - virtual bool isIRLevelProfile() const = 0; - It seems like these helper methods could still be defined using the new bitset, which would reduce some of the code

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish updated this revision to Diff 392927. snehasish added a comment. Cleanup for review - - Added some more descriptive comments. - Removed a couple of unintentional blank lines. - Removed a couple of commented lines of code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish created this revision. snehasish added reviewers: xur, davidxl. Herald added subscribers: wenlei, hiraditya. snehasish requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change refactors the ProfileKind enum in