snehasish added inline comments.

================
Comment at: llvm/include/llvm/ProfileData/InstrProf.h:281-282
 
+/// An enum describing the attributes of an instrumented profile.
+enum class InstrProfKind {
+  Unknown = 0x0,
----------------
ellis wrote:
> I've been working on a new coverage instrumentation in D116180 that I guess 
> would need to be added this this enum. The plan was to first add function 
> entry coverage, then basic block coverage.
Yes this makes the enum composable and brings it in line with the Variant mask 
encoding in the indexed profile header. Let me go ahead and submit this (after 
rebasing and testing) so that you can rebase your changes. Thanks for the heads 
up!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115393/new/

https://reviews.llvm.org/D115393

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to